Skip to content

Make status changes thread-safe#5664

Closed
Carlosespicur wants to merge 1 commit into
masterfrom
hotfix/21355
Closed

Make status changes thread-safe#5664
Carlosespicur wants to merge 1 commit into
masterfrom
hotfix/21355

Conversation

@Carlosespicur

@Carlosespicur Carlosespicur commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Description

It has been notified that multiple threads can access simultaneously to RTPS listener callbacks in DataWriterImpl/DataReaderImpl, causing multiple status changes before notifying them to DataWriterListener/DataReaderListener.

This PR fix the problem making status changes and notifications thread-safe.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
    -N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
    -N/A New feature has been added to the versions.md file (if applicable).
    -N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@github-actions github-actions Bot added the ci-pending PR which CI is running label Feb 25, 2025
@Carlosespicur
Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany March 25, 2025 06:35
@Carlosespicur
Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany March 25, 2025 08:43
@Carlosespicur
Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany March 25, 2025 10:47
@Carlosespicur
Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany March 26, 2025 09:57
@Carlosespicur
Carlosespicur force-pushed the hotfix/21355 branch 2 times, most recently from 0591ddf to 5f8c1ef Compare March 26, 2025 14:37
@Carlosespicur
Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany March 26, 2025 15:17
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur
Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany March 27, 2025 09:57
@MiguelCompany

Copy link
Copy Markdown
Member

Superseeded by #6371

@MiguelCompany
MiguelCompany deleted the hotfix/21355 branch April 20, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants