Make status changes thread-safe#5664
Closed
Carlosespicur wants to merge 1 commit into
Closed
Conversation
Carlosespicur
force-pushed
the
hotfix/21355
branch
from
March 25, 2025 06:33
c12bd8b to
ce0a897
Compare
Carlosespicur
requested review from
MiguelCompany
and removed request for
MiguelCompany
March 25, 2025 06:35
Carlosespicur
force-pushed
the
hotfix/21355
branch
from
March 25, 2025 08:41
ce0a897 to
afcb0e1
Compare
Carlosespicur
requested review from
MiguelCompany
and removed request for
MiguelCompany
March 25, 2025 08:43
Carlosespicur
force-pushed
the
hotfix/21355
branch
from
March 25, 2025 10:46
afcb0e1 to
ac39d14
Compare
Carlosespicur
requested review from
MiguelCompany
and removed request for
MiguelCompany
March 25, 2025 10:47
Carlosespicur
force-pushed
the
hotfix/21355
branch
from
March 26, 2025 09:54
ac39d14 to
0d0bf4f
Compare
Carlosespicur
requested review from
MiguelCompany
and removed request for
MiguelCompany
March 26, 2025 09:57
Carlosespicur
force-pushed
the
hotfix/21355
branch
2 times, most recently
from
March 26, 2025 14:37
0591ddf to
5f8c1ef
Compare
Carlosespicur
requested review from
MiguelCompany
and removed request for
MiguelCompany
March 26, 2025 15:17
Carlosespicur
force-pushed
the
hotfix/21355
branch
from
March 27, 2025 09:57
5f8c1ef to
80c9eb5
Compare
Carlosespicur
requested review from
MiguelCompany
and removed request for
MiguelCompany
March 27, 2025 09:57
Member
|
Superseeded by #6371 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It has been notified that multiple threads can access simultaneously to RTPS listener callbacks in DataWriterImpl/DataReaderImpl, causing multiple status changes before notifying them to DataWriterListener/DataReaderListener.
This PR fix the problem making status changes and notifications thread-safe.
Contributor Checklist
-N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
-N/A New feature has been added to the
versions.mdfile (if applicable).-N/A New feature has been documented/Current behavior is correctly described in the documentation.
Reviewer Checklist